GitHub user SharpRay opened a pull request:
https://github.com/apache/spark/pull/18404
[SPARK-18004][SQL] Make sure the date or timestamp related predicate can be
pushed down to Oracle correctly
## What changes were proposed in this pull request?
1. Override beforeFetch method in OracleDialect to finish the following two
things:
- Set Oracle's NLS_TIMESTAMP_FORMAT to '"YYYY-MM-DD HH24:MI:SS.FF" to
match java.sql.Timestamp format.
- Set Oracle's NLS_DATE_FORMAT to '"YYYY-MM-DD" to match java.sql.Date
format.
2. Timestamp and date type are the same data type in the versions of oracle
jdbc after 10g. So we should differentiate date type from timestamp type. The
related work is done in the getCatalyst method of the OracleDialect object.
## How was this patch tested?
An integration test has been added and a existing unit test has been
modified.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SharpRay/spark branch-2.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18404
----
commit c686cd9099d56232d44d81e836d099094e56bc26
Author: Zharui <[email protected]>
Date: 2017-06-23T11:36:02Z
[SPARK-18004][SQL]Make sure date or timestamp related predicate is pushed
down correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
