Github user ericsahit commented on a diff in the pull request:
https://github.com/apache/spark/pull/18268#discussion_r123969009
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -114,50 +114,79 @@ class SQLConfSuite extends QueryTest with
SharedSQLContext {
}
}
- test("reset - public conf") {
- spark.sessionState.conf.clear()
- val original = spark.conf.get(SQLConf.GROUP_BY_ORDINAL)
- try {
- assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === true)
- sql(s"set ${SQLConf.GROUP_BY_ORDINAL.key}=false")
- assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === false)
- assert(sql(s"set").where(s"key =
'${SQLConf.GROUP_BY_ORDINAL.key}'").count() == 1)
- sql(s"reset")
- assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === true)
- assert(sql(s"set").where(s"key =
'${SQLConf.GROUP_BY_ORDINAL.key}'").count() == 0)
- } finally {
- sql(s"set ${SQLConf.GROUP_BY_ORDINAL}=$original")
+ Seq("reset", s"reset ${SQLConf.GROUP_BY_ORDINAL.key}").foreach {
resetCmd =>
+ test(s"reset - public conf $resetCmd") {
+ spark.sessionState.conf.clear()
+ val original = spark.conf.get(SQLConf.GROUP_BY_ORDINAL)
+ try {
+ assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === true)
+ sql(s"set ${SQLConf.GROUP_BY_ORDINAL.key}=false")
+ assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === false)
+ assert(sql(s"set").where(s"key =
'${SQLConf.GROUP_BY_ORDINAL.key}'").count() == 1)
+ sql(resetCmd)
+ assert(spark.conf.get(SQLConf.GROUP_BY_ORDINAL) === true)
+ assert(sql(s"set").where(s"key =
'${SQLConf.GROUP_BY_ORDINAL.key}'").count() == 0)
+ } finally {
+ sql(s"set ${SQLConf.GROUP_BY_ORDINAL}=$original")
--- End diff --
Would you mean it is a duplicated clean action? I suppose the purpose is to
prevent impact of other tests..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
