Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/18419#discussion_r124058801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -100,7 +105,9 @@ object SQLExecution {
// all accumulator metrics will be 0. It will confuse people if we
show them in Web UI.
//
// A real case is the `DataFrame.count` method.
- throw new IllegalArgumentException(s"$EXECUTION_ID_KEY is already
set")
+ throw new IllegalArgumentException(s"$EXECUTION_ID_KEY is already
set, please wrap your " +
--- End diff --
Nested execution is a developer problem, not a user problem. That's why the
[original
PR](https://github.com/apache/spark/pull/17540/files#diff-ab49028253e599e6e74cc4f4dcb2e3a8R127)
did not throw `IllegalArgumentException` outside of testing. I think that
should still be how this is handled.
If this is thrown at runtime, adding the text about
`ignoreNestedExecutionId` is confusing for users, who can't (or shouldn't) set
it. A comment is more appropriate if users will see this message. If the change
to only throw during testing is added, then I think it is fine to add the text
to the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
