Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18418#discussion_r124163076 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -342,19 +343,38 @@ case class CreateNamedStruct(children: Seq[Expression]) extends CreateNamedStruc val values = ctx.freshName("values") ctx.addMutableState("Object[]", values, s"$values = null;") + // `splitExpressions` might split codes to multiple functions. The local variables of + // `LambdaVariable` can't be accessed in the functions. We need to add them into the parameters + // of the functions. + val (valExprCodes, valExprParams) = valExprs.map { expr => + val exprCode = expr.genCode(ctx) + val lambdaVars = expr.collect { --- End diff -- this looks hacky, and why you only do it for `CreateNamedStruct`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org