Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12414#discussion_r124172642
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -163,12 +163,20 @@ class RFormula @Since("1.5.0") (@Since("1.5.0")
override val uid: String)
}.toMap
// Then we handle one-hot encoding and interactions between terms.
+ var hasReferenceCategory = false
--- End diff --
I rename ```hasReferenceCategory``` to ```keepReferenceCategory``` with
default initial value ```false```. This is because if users fit with intercept,
it will not trigger ```keepReferenceCategory```, so ```keepReferenceCategory```
always as ```false```. @actuaryzhang I think ```firstString``` is not an
expressive name, if users fit with intercept, ```RFormula``` will check the
first string as well, but doesn't keep all categories. So after run pass this
code snippet, ```firstString``` is still ```true```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
