Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18174#discussion_r124214950
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -61,6 +65,9 @@ public UnsafeSorterSpillWriter(
this.file = spilledFileInfo._2();
this.blockId = spilledFileInfo._1();
this.numRecordsToWrite = numRecordsToWrite;
+ this.diskWriteBufferSize =
--- End diff --
I don't have special interest over this, but at least we should keep the
same behavior for both `ShuffleExternalSorter` class and
`UnsafeSorterSpillWriter` class, otherwise we are introducing unnecessary
complexity. Could you please update this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
