Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18430#discussion_r124250699
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -321,7 +322,7 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
// scan for modified applications, replay and merge them
val logInfos: Seq[FileStatus] = statusList
.filter { entry =>
- val prevFileSize =
fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+ val prevFileSize =
fileToAppInfo.asScala.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
--- End diff --
`asScala` produces a wrapper, right? in which case this can be called once,
at declaration above. If it produces a clone, this doesn't work anyway!
But why is this needed anyway? you can `get` elements from the Java map
already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
