Github user NarineK commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14431#discussion_r124327866
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1465,10 +1464,10 @@ setMethod("dapplyCollect",
     #'
     #' Result
     #' ---------
    -#' Model  (Intercept)  Sepal_Width  Petal_Length  Petal_Width
    -#' 1        0.699883    0.3303370    0.9455356    -0.1697527
    -#' 2        1.895540    0.3868576    0.9083370    -0.6792238
    -#' 3        2.351890    0.6548350    0.2375602     0.2521257
    +#' Model  Species     (Intercept)  Sepal_Width  Petal_Length  Petal_Width
    --- End diff --
    
    In the past we had a discussion about backward compatibility with shivaram.
    https://github.com/apache/spark/pull/14431#issuecomment-236643502
    
    I think I didn't push R changes, because I wanted to be able to access the 
grouping columns on sql side first. Without being able to access the grouping 
columns I couldn't find a way to keep backward compatibility without breaking 
anything.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to