Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124455032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,19 @@ abstract class Optimizer(sessionCatalog:
SessionCatalog, conf: SQLConf)
}
/**
+ * Remove useless DISTINCT for MAX and MIN.
+ * This rule should be applied before RewriteDistinctAggregates.
+ */
+object EliminateDistinct extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan
transformExpressions {
+ case AggregateExpression(max: Max, mode: AggregateMode, true, _) =>
--- End diff --
in general i'm not a big fan of using extractors unless we need almost all
arguments ... it makes refactoring a lot more complicated. Extractors are
over/abused in Catalyst (there are some code that use extractors when they are
simply doing type matching).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
