Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18425#discussion_r124590098
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,6 +396,12 @@ public double getDouble(int rowId) {
}
}
+ @Override
+ public void getDoubles(double[] dst, int rowId, int count) {
+ assert(dictionary == null);
+ System.arraycopy(byteData, rowId, dst, 0, count);
+ }
+
--- End diff --
@dongjoon-hyun for example, [these
lines](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala#L763-L766)
uses this new API. Would it be better to add additional tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
