Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2575#discussion_r18148901
--- Diff:
examples/src/main/scala/org/apache/spark/examples/GroupByTest.scala ---
@@ -44,11 +44,11 @@ object GroupByTest {
arr1(i) = (ranGen.nextInt(Int.MaxValue), byteArr)
}
arr1
- }.cache
+ }.cache()
--- End diff --
Yes, all intentional. Parens should be used in Scala when methods have side
effects, and @Override should be used in Java where an override is intended.
These are just small matters of style but think worth standardizing to match
other source and common practice while changing nearby code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
