Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18388#discussion_r124744067
  
    --- Diff: 
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
 ---
    @@ -257,4 +257,31 @@ public Properties cryptoConf() {
         return CryptoUtils.toCryptoConf("spark.network.crypto.config.", 
conf.getAll());
       }
     
    +  /**
    +   * When memory usage of Netty is above this water mark, it's regarded as 
memory shortage.
    --- End diff --
    
    This is inconsistent with the executor memory configuration. For executor 
memory, we have `spark.executor.memory` for heap size, and 
`spark.memory.offHeap.size` for off-heap size, and these 2 together is the 
total memory consumption for each executor process.
    
    Now we have a single config for shuffle service total memory consumption, 
this seems better, shall we fix the executor memory config?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to