GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/18472
[SPARK-21253][Core]Fix a bug that StreamCallback may not be notified if
network errors happen
## What changes were proposed in this pull request?
If a network error happens before processing StreamResponse/StreamFailure
events, StreamCallback.onFailure won't be called.
This PR fixes `failOutstandingRequests` to also notify outstanding
StreamCallbacks.
## How was this patch tested?
The new unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark fix-stream-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18472
----
commit fb98f3f20f681106ac9a06b57c7a55ca083653fc
Author: Shixiong Zhu <[email protected]>
Date: 2017-06-29T23:56:46Z
Fix a bug that StreamCallback may not be notified if network errors happen
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
