Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18483#discussion_r124995524 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -94,4 +108,21 @@ object InternalRow { /** Returns an empty [[InternalRow]]. */ val empty = apply() + + /** + * Copies the given value if it's string/struct/array/map type. + */ + def copyValue(value: Any): Any = { + if (value.isInstanceOf[UTF8String]) { + value.asInstanceOf[UTF8String].copy() + } else if (value.isInstanceOf[InternalRow]) { + value.asInstanceOf[InternalRow].copy() + } else if (value.isInstanceOf[ArrayData]) { + value.asInstanceOf[ArrayData].copy() + } else if (value.isInstanceOf[MapData]) { + value.asInstanceOf[MapData].copy() + } else { --- End diff -- Should we also support `Clonable`? This might be an escape door for developers who are putting their own objects in `InternalRow`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org