Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18471#discussion_r125029078
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -52,8 +52,8 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
- def newBroadcast[T: ClassTag](value_ : T, isLocal: Boolean):
Broadcast[T] = {
- broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement())
+ def newBroadcast[T: ClassTag](_value: T, isLocal: Boolean): Broadcast[T]
= {
--- End diff --
I think it's not about adding `_` to the name of private val, but kind of
avoiding name conflict if 2 variables have similar meaning. At least this is
fine to me, I also do this a lot...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
