Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2469#discussion_r18175255
  
    --- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClientImpl.scala 
---
    @@ -69,7 +74,32 @@ private class YarnRMClientImpl(args: 
ApplicationMasterArguments) extends YarnRMC
         appAttemptId
       }
     
    -  override def getProxyHostAndPort(conf: YarnConfiguration) = 
WebAppUtils.getProxyHostAndPort(conf)
    +  override def getAmIpFilterParams(conf: YarnConfiguration, proxyBase: 
String) = {
    --- End diff --
    
    Mind if I skip this one? That would make this method not consistent with 
the others, it would make the line go over 100 chars, and well, it just feels a 
little redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to