Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18481#discussion_r125110360
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -200,6 +200,31 @@ NULL
     #' head(select(tmp, sort_array(tmp$v1, asc = FALSE)))}
     NULL
     
    +#' Window functions for Column operations
    +#'
    +#' Window functions defined for \code{Column}.
    +#'
    +#' @param x In \code{lag} and \code{lead}, it is the column as a character 
string or a Column
    +#'          to compute on. In \code{ntile}, it is the number of ntile 
groups.
    +#' @param offset In \code{lag}, the number of rows back from the current 
row from which to obtain
    +#'               a value. In \code{lead}, the number of rows after the 
current row from which to
    +#'               obtain a value. If not specified, the default is 1.
    +#' @param ... additional argument(s).
    +#' @name column_window_functions
    +#' @rdname column_window_functions
    +#' @family window functions
    +#' @examples
    +#' \dontrun{
    +#' # Dataframe used throughout this doc
    +#' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))
    +#' ws <- orderBy(windowPartitionBy("am"), "hp")
    +#' tmp <- mutate(df, dist = over(cume_dist(), ws), dense_rank = 
over(dense_rank(), ws),
    --- End diff --
    
    is this comment still useful, or obvious without it?
    ```
    #'   # Get ntile group id (1-4) for hp
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to