Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17451#discussion_r125154035
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -274,6 +274,29 @@ class Word2VecModel private[ml] (
wordVectors.findSynonyms(word, num)
}
+ /**
--- End diff --
this seems a little weird, it feels like it would be more natural to call
the `findSynonymsArray` from python then do the map in Python, but I guess this
might be a little faster
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
