Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18479#discussion_r125154131
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala
---
@@ -77,37 +77,6 @@ class BasicStatsEstimationSuite extends
StatsEstimationTestBase {
checkStats(globalLimit, stats)
}
- test("sample estimation") {
- val sample = Sample(0.0, 0.5, withReplacement = false, (math.random *
1000).toLong, plan)
- checkStats(sample, Statistics(sizeInBytes = 60, rowCount = Some(5)))
-
- // Child doesn't have rowCount in stats
- val childStats = Statistics(sizeInBytes = 120)
- val childPlan = DummyLogicalPlan(childStats, childStats)
- val sample2 =
- Sample(0.0, 0.11, withReplacement = false, (math.random *
1000).toLong, childPlan)
- checkStats(sample2, Statistics(sizeInBytes = 14))
- }
-
- test("estimate statistics when the conf changes") {
- val expectedDefaultStats =
- Statistics(
- sizeInBytes = 40,
- rowCount = Some(10),
- attributeStats = AttributeMap(Seq(
- AttributeReference("c1", IntegerType)() -> ColumnStat(10,
Some(1), Some(10), 0, 4, 4))))
- val expectedCboStats =
- Statistics(
- sizeInBytes = 4,
- rowCount = Some(1),
- attributeStats = AttributeMap(Seq(
- AttributeReference("c1", IntegerType)() -> ColumnStat(1,
Some(5), Some(5), 0, 4, 4))))
-
- val plan = DummyLogicalPlan(defaultStats = expectedDefaultStats,
cboStats = expectedCboStats)
- checkStats(
- plan, expectedStatsCboOn = expectedCboStats, expectedStatsCboOff =
expectedDefaultStats)
- }
--- End diff --
Need to add them back in the follow-up PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
