Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18451#discussion_r125174365
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
    @@ -68,5 +68,15 @@ private case object OracleDialect extends JdbcDialect {
         case _ => None
       }
     
    +  override def compileValue(value: Any): Any = value match {
    +    // Special treatment for the literal representations of
    +    // Oracle's Timestamp/Date types.
    +    case stringValue: String => s"'${escapeSql(stringValue)}'"
    +    case timestampValue: Timestamp => "{ts '" + timestampValue + "'}"
    --- End diff --
    
    Add one line before this.
    > The JDBC drivers support date literals in SQL statements written in the 
format: {d 'yyyy-mm-dd'} and timestamp literals in SQL statements written in 
the format: {ts 'yyyy-mm-dd hh:mm:ss.f...'}. For details, see 'Oracle Database 
JDBC Developer’s Guide and Reference, 11g Release 1 (11.1)' Appendix A 
Reference Information


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to