Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17758#discussion_r125205974
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -154,14 +144,11 @@ case class CreateViewCommand(
} else if (tableMetadata.tableType != CatalogTableType.VIEW) {
throw new AnalysisException(s"$name is not a view")
} else if (replace) {
- // Detect cyclic view reference on CREATE OR REPLACE VIEW.
- val viewIdent = tableMetadata.identifier
- checkCyclicViewReference(analyzedPlan, Seq(viewIdent), viewIdent)
--- End diff --
To pass the existing tests, I moved `checkCyclicViewReference` into
`rules`. Since the duplication checks also catch the cyclic cases, I think we
need to check the cyclic cases first, and then check the name duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
