Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/18494
  
    Unfortunately, the comments in the test cases of `SQLMetricsSuite` are 
out-of-dated. Anyway, could you add a test case to `SQLMetricsSuite` for 
verifying the logics. Below is an example.
    
    ```Scala
      test("SortMergeJoin(left-anti) metrics when right table is empty") {
        val testDataForJoin = testData2.filter("a < 0") // Empty but not 
optimized to EmptyRDD
        testDataForJoin.createOrReplaceTempView("testDataForJoin")
        withTempView("testDataForJoin") {
          val df = spark.sql(
            "SELECT * FROM testData2 ANTI JOIN testDataForJoin ON testData2.a = 
testDataForJoin.a")
          testSparkPlanMetrics(df, 1, Map(
            0L -> ("SortMergeJoin", Map(
              "number of output rows" -> 6L)))
          )
        }
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to