Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18510#discussion_r125238823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -60,7 +60,7 @@ case class CreateFunctionCommand(
// We first load resources and then put the builder in the function
registry.
// Please note that it is allowed to overwrite an existing temp
function.
catalog.loadFunctionResources(resources)
- catalog.registerFunction(func, ignoreIfExists = false)
+ catalog.registerFunction(func, overrideIfExists = false)
--- End diff --
This looks a bit weird. The above comment says `Please note that it is
allowed to overwrite an existing temp function.`. But we don't override it if
it exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
