Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17758#discussion_r125270419
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -87,6 +87,14 @@ case class DataSource(
lazy val providingClass: Class[_] =
DataSource.lookupDataSource(className)
lazy val sourceInfo: SourceInfo = sourceSchema()
private val caseInsensitiveOptions = CaseInsensitiveMap(options)
+ private val equality = sparkSession.sessionState.conf.resolver
+
+ userSpecifiedSchema.foreach { dataSchema =>
+ SchemaUtils.checkColumnNameDuplication(
+ dataSchema.map(_.name), "in the data schema", equality)
+ }
+ SchemaUtils.checkColumnNameDuplication(
+ partitionColumns, "in the partition schema", equality)
--- End diff --
@cloud-fan We need to check the duplication for `bucketSpec` here? The
current version also could catch the case in `bucketSpec` like;
```
scala> Seq((1, 2)).toDF("a", "b").write.bucketBy(3, "a",
"a").saveAsTable("t")
org.apache.spark.sql.AnalysisException: Found duplicate column(s) in the
bucket: `a`;
at
org.apache.spark.sql.util.SchemaUtils$.checkColumnNameDuplication(SchemaUtils.scala:85)
at
org.apache.spark.sql.util.SchemaUtils$.checkColumnNameDuplication(SchemaUtils.scala:67)
at
org.apache.spark.sql.execution.datasources.PreprocessTableCreation.normalizeBucketSpec(rules.scala:289)
at
org.apache.spark.sql.execution.datasources.PreprocessTableCreation.org$apache$spark$sql$execution$datasources$PreprocessTableCreation$$normalizeCatalogTable(rules.scala:232)
at
org.apache.spark.sql.execution.datasources.PreprocessTableCreation$$anonfun$apply$2.applyOrElse(rules.scala:197)
at
org.apache.spark.sql.execution.datasources.PreprocessTableCreation$$anonfun$apply$2.applyOrElse(rules.scala:76)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
