Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/2455#discussion_r18189085
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -53,56 +81,237 @@ trait RandomSampler[T, U] extends Pseudorandom with
Cloneable with Serializable
* @tparam T item type
*/
@DeveloperApi
-class BernoulliSampler[T](lb: Double, ub: Double, complement: Boolean =
false)
+class BernoulliPartitionSampler[T](lb: Double, ub: Double, complement:
Boolean = false)
extends RandomSampler[T, T] {
- private[random] var rng: Random = new XORShiftRandom
+ // epsilon slop to avoid failure from floating point jitter
--- End diff --
It doesn't affect the output, so I didn't spend the code/computation on
clamping it. The only reason I put in the checks at all was because I felt
like it might catch logic errors in calling code. For example, if somebody
sampled with fraction '-1.0', it could cheerfully return an empty data set, but
that would more likely be an error somewhere. But -0.0001 is more likely to be
just rounding jitter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
