Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18522#discussion_r125379907
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala ---
@@ -76,7 +76,11 @@ private[spark] class FileAppender(inputStream:
InputStream, file: File, bufferSi
}
}
} {
- closeFile()
+ try {
+ inputStream.close()
--- End diff --
Yes,you are right.
But this function is only used in `ExecutorRunner`, also if an exception
occurs within this function,this will ensure the inputStream is closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
