Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18159#discussion_r125389753
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -314,21 +339,40 @@ object FileFormatWriter extends Logging {
recordsInFile = 0
releaseResources()
+ numOutputRows += recordsInFile
newOutputWriter(fileCounter)
}
val internalRow = iter.next()
+ val startTime = System.nanoTime()
currentWriter.write(internalRow)
+ timeOnCurrentFile += (System.nanoTime() - startTime)
--- End diff --
instead of tracking the time here, how about we do it in `newOutputWriter`?
```
var startTime = -1
def newOutputWriter {
if (startTime == -1) {
startTime = System.nanoTime()
} else {
val currentTime = System.nanoTime()
totalWritingTime += currentTime - startTime
startTime = currentTime
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
