Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18191407
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -34,9 +36,11 @@ private[spark] trait SchedulerBackend {
/**
* The application ID associated with the job, if any.
+ * It is expected that the subclasses of TaskScheduler or
SchedulerBackend
+ * override this method and return an unique application ID.
*
- * @return The application ID, or None if the backend does not provide
an ID.
+ * @return The application ID, if the backend does not provide an ID.
*/
- def applicationId(): Option[String] = None
+ def applicationId() = new
ApplicationId(System.currentTimeMillis.toString)
--- End diff --
Good catch RE: semantics. How about storing the default id in a private
instance variable in SchedulerBackend then returning that via the default
`applicationId()` implementation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
