Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18529#discussion_r125492854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -588,12 +591,14 @@ case class MapObjects private(
case _ => genFunction.value
}
- val loopNullCheck = inputDataType match {
- case _: ArrayType => s"$loopIsNull =
${genInputData.value}.isNullAt($loopIndex);"
- // The element of primitive array will never be null.
- case ObjectType(cls) if cls.isArray &&
cls.getComponentType.isPrimitive =>
- s"$loopIsNull = false"
- case _ => s"$loopIsNull = $loopValue == null;"
+ val loopNullCheck = if (loopIsNull != "false") {
+ ctx.addMutableState("boolean", loopIsNull, "")
+ inputDataType match {
+ case _: ArrayType => s"$loopIsNull =
${genInputData.value}.isNullAt($loopIndex);"
+ case _ => s"$loopIsNull = $loopValue == null;"
--- End diff --
Why do you remove lines 594-595 in the original code? Can we always ensure
primitive type array sets `"false"` into `loopIsNull`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
