Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18537#discussion_r125578393
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -777,15 +778,34 @@ class ALSSuite
}
}
-class ALSCleanerSuite extends SparkFunSuite {
+class ALSCleanerSuite extends SparkFunSuite with BeforeAndAfterEach {
+
+ private var localDir: File = _
--- End diff --
I don't see why this helps. Having state in the test class is undesirable,
and the tests already configure a new conf and clean up the local dir in a
finally block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
