Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18533#discussion_r125578949
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/StarSchemaDetection.scala
 ---
    @@ -28,7 +28,9 @@ import org.apache.spark.sql.internal.SQLConf
     /**
      * Encapsulates star-schema detection logic.
      */
    -case class StarSchemaDetection(conf: SQLConf) extends PredicateHelper {
    +object StarSchemaDetection extends PredicateHelper {
    +
    +  private def conf = SQLConf.get
    --- End diff --
    
    Can we remove `import org.apache.spark.sql.internal.SQLConf`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to