Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17995#discussion_r125605561
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
 ---
    @@ -106,4 +105,13 @@ object BinaryClassificationEvaluator extends 
DefaultParamsReadable[BinaryClassif
     
       @Since("1.6.0")
       override def load(path: String): BinaryClassificationEvaluator = 
super.load(path)
    +
    +  /** String name for `areaUnderROC` metric name. */
    +  private[spark] val AreaUnderROC: String = "areaUnderROC"
    --- End diff --
    
    Can we make it ```private[BinaryClassificationEvaluator]```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to