Github user bogdanrdc commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18455#discussion_r125662252
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -274,24 +278,32 @@ case class InSet(child: Expression, hset: Set[Any]) 
extends UnaryExpression with
         }
       }
     
    -  def getHSet(): Set[Any] = hset
    +  @transient private[this] lazy val set = child.dataType match {
    +    case _: StructType =>
    --- End diff --
    
    I checked and indeed it is needed for ArrayType too. MapType is not 
comparable.
    I think dealing with uncomparable types should be different issue. It 
wouldn't work before either. In.doCodeGen would fail with 
IllegalArgumentException. EqualTo has a check specifically for Map to throw 
AnalysisException. That could be a fix. Or implement comparing for Maps.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to