Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18536#discussion_r125697276
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -818,15 +818,13 @@ class ALSCleanerSuite extends SparkFunSuite {
FileUtils.listFiles(localDir, TrueFileFilter.INSTANCE,
TrueFileFilter.INSTANCE).asScala.toSet
try {
conf.set("spark.local.dir", localDir.getAbsolutePath)
- val sc = new SparkContext("local[2]", "test", conf)
+ val sc = new SparkContext("local[2]", "ALSCleanerSuite", conf)
try {
sc.setCheckpointDir(checkpointDir.getAbsolutePath)
// Generate test data
val (training, _) = ALSSuite.genImplicitTestData(sc, 20, 5, 1,
0.2, 0)
// Implicitly test the cleaning of parents during ALS training
val spark = SparkSession.builder
- .master("local[2]")
--- End diff --
If users set it to `local[4]` that is different from the pre-built spark
context, I think we need to issue an exception? If they are identical, maybe we
can simply ignore it? cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
