Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18523#discussion_r125804032
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -113,12 +113,15 @@ class VectorAssembler @Since("1.4.0")
(@Since("1.4.0") override val uid: String)
override def transformSchema(schema: StructType): StructType = {
val inputColNames = $(inputCols)
val outputColName = $(outputCol)
- val inputDataTypes = inputColNames.map(name => schema(name).dataType)
- inputDataTypes.foreach {
- case _: NumericType | BooleanType =>
- case t if t.isInstanceOf[VectorUDT] =>
- case other =>
- throw new IllegalArgumentException(s"Data type $other is not
supported.")
+ val incorrectColumns = inputColNames.flatMap { name =>
--- End diff --
I see, but the type of ```inputColNames``` is not ```Option[T]```, so here
we can still use ```map```. This doesn't matter, LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
