Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16422#discussion_r125805788
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -320,10 +320,15 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder(conf) {
        * Create a [[DescribeTableCommand]] logical plan.
        */
       override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan 
= withOrigin(ctx) {
    -    // Describe column are not supported yet. Return null and let the 
parser decide
    -    // what to do with this (create an exception or pass it on to a 
different system).
         if (ctx.describeColName != null) {
    -      null
    +      if (ctx.partitionSpec != null) {
    +        throw new ParseException("DESC TABLE COLUMN for a specific 
partition is not supported", ctx)
    +      } else {
    +        DescribeColumnCommand(
    +          visitTableIdentifier(ctx.tableIdentifier),
    +          ctx.describeColName.getText,
    +          ctx.FORMATTED != null)
    --- End diff --
    
    I just tested in hive 2.1, it only show detailed column info with 
`formatted`, shall we keep the same as hive?
    ```
    hive> desc test key;
    OK
    key                         int                     from deserializer   
    Time taken: 0.063 seconds, Fetched: 1 row(s)
    hive> desc extended test key;
    OK
    key                         int                     from deserializer   
    Time taken: 0.053 seconds, Fetched: 1 row(s)
    hive> desc formatted test key;
    OK
    # col_name                  data_type               min                     
max                     num_nulls               distinct_count          
avg_col_len             max_col_len             num_trues               
num_falses              comment             
                                                                                
 
    key                         int                     1                       
2                       0                       2                               
                                                                                
        from deserializer   
    Time taken: 0.067 seconds, Fetched: 3 row(s)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to