Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18509#discussion_r125819776
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats:
EventTimeStats = EventTime
case class EventTimeWatermarkExec(
eventTime: Attribute,
delay: CalendarInterval,
- child: SparkPlan) extends SparkPlan {
+ child: SparkPlan) extends UnaryExecNode {
--- End diff --
Hm, I checked the Spark code style guide and it doesn't say anything about
`override`. Then this is good to me.
By the way, could you spend one minute creating a JIRA ticket for this PR
since it changes codes, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
