Github user pwoody commented on a diff in the pull request:
https://github.com/apache/spark/pull/18542#discussion_r125868099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -150,7 +163,7 @@ object FileFormatWriter extends Logging {
)
// We should first sort by partition columns, then bucket id, and
finally sorting columns.
- val requiredOrdering = partitionColumns ++ bucketIdExpression ++
sortColumns
+ val requiredOrdering = partitionColumns ++ bucketSortExpression ++
sortColumns
--- End diff --
Yeah - if the bucketSortExpression is Option.None it will just consider
partition columns/sort columns for ordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
