Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18503#discussion_r126077681
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java
---
@@ -62,7 +62,7 @@ public UnsafeRow appendRow(Object kbase, long koff, int
klen,
keyRowId = numRows;
keyRow.pointTo(base, recordOffset, klen);
- valueRow.pointTo(base, recordOffset + klen, vlen + 4);
--- End diff --
@ooq thank you for pointing out interesting discussion.
This discussion seems to make sense for page management. The question of
@cloud-fan and me is whether `valueRow` uses only `vlen`. I think that `+4` is
for page management.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
