Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r126160543
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -73,7 +73,9 @@ public UnsafeSorterSpillReader(
}
final InputStream bs =
- new NioBufferedFileInputStream(file, (int) bufferSizeBytes);
+ new ReadAheadInputStream(
+ new NioBufferedFileInputStream(file, (int) bufferSizeBytes),
+ (int)bufferSizeBytes, (int)bufferSizeBytes / 2);
--- End diff --
Do we have a test on what would be the best threshold? Should we consider
make this configurable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
