Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18394#discussion_r126241078
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -373,6 +373,11 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging with Seria
         Option(settings.get(key)).orElse(getDeprecatedConfig(key, this))
       }
     
    +  /** Get an optional value, applying variable substitution. */
    +  private[spark] def getWithSubstitution(key: String): Option[String] = {
    --- End diff --
    
    Hmmm... if I remember the original discussion on the PR that added this 
code, I chose not to do it to avoid breaking people who might have these 
references in their configs even though the code wasn't doing substitution.
    
    It might be a good idea to do substitution for all config entries, 
registered or not, but I'd rather do that in a separate change (and then this 
private API could be removed).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to