Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18565#discussion_r126242576
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -151,15 +152,27 @@ private void failRemainingBlocks(String[]
failedBlockIds, Throwable e) {
}
}
+ private static synchronized boolean renameFile(File src, File dest) {
+ if (dest.exists()) {
+ if (!dest.delete()) {
--- End diff --
Why delete the existing file? If it's already there, then it must be done
by another `DownloadCallback`. It should be fine to just mark DownloadCallback
successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
