Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18565#discussion_r126285966
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleClient.java
---
@@ -42,5 +42,13 @@ public abstract void fetchBlocks(
String execId,
String[] blockIds,
BlockFetchingListener listener,
- File[] shuffleFiles);
+ boolean toDisk,
+ TmpFileCreater tmpFileCreater);
+
+ /**
+ * An interface to provide approach to create tmp file.
+ */
+ public interface TmpFileCreater {
--- End diff --
shall we move it to a separated file? We may use it outside of
`ShuffleClient` in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
