Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18579#discussion_r126306255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -302,37 +302,30 @@ class CodegenContext {
}
/**
- * Instantiates all nested, private sub-classes as objects to the
`OuterClass`
+ * Declares all function code. If the added functions are too many,
split them into nested
+ * sub-classes to avoid hitting Java compiler constant pool limitation.
*/
- private[sql] def initNestedClasses(): String = {
+ def declareAddedFunctions(): String = {
+ val inlinedFunctions = classFunctions(outerClassName).values
--- End diff --
They are different. This line inline pure functions which are not in the
nested classes, and the next line inline these nested classes containing other
functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
