Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18574#discussion_r126330636
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ---
    @@ -112,7 +112,12 @@ class SimpleFunctionRegistry extends FunctionRegistry {
             throw new AnalysisException(s"undefined function $name")
           }
         }
    -    func(children)
    +    try {
    +      func(children)
    --- End diff --
    
    Although this is the simplest fix, I think ideally it's the 
`FunctionBuilder`'s responsibility to check invalid number of arguments, like 
the built-in function's `FunctionBuilder` does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to