Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18571#discussion_r126335167
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -137,4 +137,22 @@ class OrderingSuite extends SparkFunSuite with
ExpressionEvalHelper {
// verify that we can support up to 5000 ordering comparisons, which
should be sufficient
GenerateOrdering.generate(Array.fill(5000)(sortOrder))
}
+
+ test("SPARK-21344: BinaryType comparison does signed byte array
comparison") {
+ val b1 = Array[Byte](1) // 0x01
+ val b2 = Array[Byte](-1) // 0xff
--- End diff --
Also, it looks better to check the boundary values like `-128` and `127`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
