Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/18584
  
    > I don't think that the shading will break any Spark application that 
depends on the PMMLExportable trait
    
    Hmm, I'd be more comfortable if one of you guys actually tested this to be 
true:
    
    - extend the old trait in a user class
    - try to run that class with the new Spark with the shaded dependency
    
    Because Scala traits are weird (bytecode is copied from the trait into the 
class that extends it), there could be dangling references to the non-shaded 
classes, even if those classes are not explicitly exposed in the trait.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to