Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18305
@MLnick I remembered a bug I hit several months ago: we forgot to destroy a
broadcast variable in source code, but it throws exception after we add destroy
explicitly. This is because we put broadcast variable in wrong place, it works
well if we don't destroy it explicitly. This could be avoid if we add
corresponding test cases with destroy explicitly. If not, we may forgot to
destroy broadcast variable explicitly in source code, which is likely to lead
to potential bugs. This is why I'm prefer to keep consistent logic in both
source and test. I think it's trivial issue for this case. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
