Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r126607452
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DataSourceTest.scala ---
@@ -20,14 +20,17 @@ package org.apache.spark.sql.sources
import org.apache.spark.rdd.RDD
import org.apache.spark.sql._
import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.UTF8String
private[sql] abstract class DataSourceTest extends QueryTest {
- protected def sqlTest(sqlString: String, expectedAnswer: Seq[Row]) {
+ protected def sqlTest(sqlString: String, expectedAnswer: Seq[Row],
enableRegex: String = "true") {
--- End diff --
`enableRegex: String = "true"` -> `enableRegex: Boolean = false`
Could you change the type to Boolean and call .toString below and set the
default to `false`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
