Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18428#discussion_r127057083
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -183,8 +198,15 @@ private[ml] object ValidatorParams {
val paramPairs = pMap.map { case pInfo: Map[String, String] =>
val est = uidToParams(pInfo("parent"))
val param = est.getParam(pInfo("name"))
- val value = param.jsonDecode(pInfo("value"))
- param -> value
+ if (!pInfo.contains("isJson") ||
+ (pInfo.contains("isJson") &&
pInfo("isJson").toBoolean.booleanValue())) {
--- End diff --
style nit: indent line 202 +1 space
Also, could you please add a comment saying that SPARK-21221 introduced the
"isJson" field?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
